[Hub Generated] Review request for Microsoft.Capacity to add version stable/2022-03-01 #18244

gaoyp830 · 2022-03-15T01:05:52Z

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

Changelog

Add a changelog entry for this PR by answering the following questions:

What's the purpose of the update?
- new service onboarding
- new API version
- update existing version for new feature
- update existing version to fix swagger quality issue in s360
- Other, please clarify
When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
If updating an existing version, please select the specific language SDKs and CLIs that must be refreshed after the swagger is published.
- SDK of .NET (need service team to ensure code readiness)
- SDK of Python
- SDK of Java
- SDK of Js
- SDK of Go
- PowerShell
- CLI
- Terraform
- No refresh required for updates in this PR

Contribution checklist:

I commit to follow the Breaking Change Policy of "no breaking changes"
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

Change to data plane APIs

Adding new properties

All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.
- Adding a new service
- Adding new API(s)
- Adding a new API version
  -[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

Removing API(s) in a stable version
Removing properties in a stable version
Removing API version(s) in a stable version
Updating API in a stable or public preview version with Breaking Change Validation errors
Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

…-01 to version 2022-03-01

openapi-workflow-bot · 2022-03-15T01:05:55Z

Hi, @gaoyp830 Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

openapi-pipeline-app · 2022-03-15T01:05:56Z

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]

There are no breaking changes.

️⚠️LintDiff: 0 Warnings warning [Detail]

Linted configuring files (Based on source branch, openapi-validator v1.12.1 , classic-openapi-validator v1.2.2 )
- reservations/resource-manager/readme.md tag:package-2022-03
Linted configuring files (Based on target branch, openapi-validator v1.12.1 , classic-openapi-validator v1.2.2 )
- reservations/resource-manager/readme.md tag:default

The following errors/warnings exist before current PR submission:

Only 30 items are listed, please refer to log for more details.

Rule	Message
`❌` R2018 - XmsEnumValidation	The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.Capacity/stable/2022-03-01/reservations.json#L955
`❌` R2018 - XmsEnumValidation	The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.Capacity/stable/2022-03-01/reservations.json#L1009
`❌` R2018 - XmsEnumValidation	The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.Capacity/stable/2022-03-01/reservations.json#L1452
`❌` R2018 - XmsEnumValidation	The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.Capacity/stable/2022-03-01/reservations.json#L1464
`❌` R2018 - XmsEnumValidation	The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.Capacity/stable/2022-03-01/reservations.json#L1475
`❌` R4039 - ParametersOrder	The parameters:reservationId,reservationOrderId should be kept in the same order as they present in the path. Location: Microsoft.Capacity/stable/2022-03-01/reservations.json#L487
`❌` R4039 - ParametersOrder	The parameters:reservationId,reservationOrderId should be kept in the same order as they present in the path. Location: Microsoft.Capacity/stable/2022-03-01/reservations.json#L576
`❌` R4041 - XmsIdentifierValidation	Missing identifier id in array item property Location: Microsoft.Capacity/stable/2022-03-01/reservations.json#L1082
`❌` R4041 - XmsIdentifierValidation	Missing identifier id in array item property Location: Microsoft.Capacity/stable/2022-03-01/reservations.json#L1089
`❌` R4041 - XmsIdentifierValidation	Missing identifier id in array item property Location: Microsoft.Capacity/stable/2022-03-01/reservations.json#L1201
`❌` R4041 - XmsIdentifierValidation	Missing identifier id in array item property Location: Microsoft.Capacity/stable/2022-03-01/reservations.json#L1220
`❌` R4041 - XmsIdentifierValidation	Missing identifier id in array item property Location: Microsoft.Capacity/stable/2022-03-01/reservations.json#L1237
`❌` R4041 - XmsIdentifierValidation	Missing identifier id in array item property Location: Microsoft.Capacity/stable/2022-03-01/reservations.json#L1391
`❌` R4041 - XmsIdentifierValidation	Missing identifier id in array item property Location: Microsoft.Capacity/stable/2022-03-01/reservations.json#L1592
`❌` R4041 - XmsIdentifierValidation	Missing identifier id in array item property Location: Microsoft.Capacity/stable/2022-03-01/reservations.json#L1812
`❌` R4041 - XmsIdentifierValidation	Missing identifier id in array item property Location: Microsoft.Capacity/stable/2022-03-01/reservations.json#L1819
`❌` R4041 - XmsIdentifierValidation	Missing identifier id in array item property Location: Microsoft.Capacity/stable/2022-03-01/reservations.json#L1848
`❌` R4041 - XmsIdentifierValidation	Missing identifier id in array item property Location: Microsoft.Capacity/stable/2022-03-01/reservations.json#L1855
`❌` R4041 - XmsIdentifierValidation	Missing identifier id in array item property Location: Microsoft.Capacity/stable/2022-03-01/reservations.json#L1871
`❌` R4041 - XmsIdentifierValidation	Missing identifier id in array item property Location: Microsoft.Capacity/stable/2022-03-01/reservations.json#L2084
`❌` R4041 - XmsIdentifierValidation	Missing identifier id in array item property Location: Microsoft.Capacity/stable/2022-03-01/reservations.json#L2436
`❌` R4041 - XmsIdentifierValidation	Missing identifier id in array item property Location: Microsoft.Capacity/stable/2022-03-01/reservations.json#L2651
⚠️ R1003 - ListInOperationName	Since operation 'ReservationOrder_ChangeDirectory' response has model definition 'array', it should be of the form '_list'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Capacity/stable/2022-03-01/reservations.json#L852
⚠️ R1006 - PutInOperationName	'PUT' operation 'ReservationOrder_Purchase' should use method name 'Create'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Capacity/stable/2022-03-01/reservations.json#L255
⚠️ R2001 - AvoidNestedProperties	Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.Capacity/stable/2022-03-01/reservations.json#L1043
⚠️ R2001 - AvoidNestedProperties	Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.Capacity/stable/2022-03-01/reservations.json#L1064
⚠️ R2001 - AvoidNestedProperties	Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.Capacity/stable/2022-03-01/reservations.json#L1073
⚠️ R2001 - AvoidNestedProperties	Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.Capacity/stable/2022-03-01/reservations.json#L1550
⚠️ R2001 - AvoidNestedProperties	Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.Capacity/stable/2022-03-01/reservations.json#L1584
⚠️ R2001 - AvoidNestedProperties	Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.Capacity/stable/2022-03-01/reservations.json#L1738

️⚠️Avocado: 1 Warnings warning [Detail]

Rule	Message
⚠️ MULTIPLE_API_VERSION	The default tag contains multiple API versions swaggers. readme: specification/reservations/resource-manager/readme.md tag: specification/reservations/resource-manager/readme.md#tag-package-2022-03

️❌~[Staging] ApiReadinessCheck: 1 Errors, 0 Warnings failed [Detail]

Rule	Message
`❌` API Readiness check failed. Please make sure your service is deployed.	"code: InvalidResourceType, message: The resource type 'operations' could not be found in the namespace 'Microsoft.Capacity' for api version '2022-03-01'. The supported api-versions are '2017-11-01, 2018-06-01, 2019-04-01, 2020-10-01-preview, 2017-11-01-beta, 2018-06-01-beta, 2019-04-01-beta, 2020-10-01-beta'."

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️⚠️Cross-Version Breaking Changes: 9 Warnings warning [Detail]

Compared Swaggers (Based on Oad v0.9.3)
- current:stable/2022-03-01/reservations.json compared with base:stable/2021-07-01/reservations.json
- current:stable/2022-03-01/reservations.json compared with base:preview/2020-10-01-preview/reservations.json

The following breaking changes are detected by comparison with latest preview version:

Rule	Message
⚠️ 1007 - RemovedClientParameter	The new version is missing a client parameter that was found in the old version. Was 'OperationResultIdParameter' removed or renamed? New: Microsoft.Capacity/stable/2022-03-01/reservations.json#L2706:3 Old: Microsoft.Capacity/preview/2020-10-01-preview/reservations.json#L2135:3
⚠️ 1023 - TypeFormatChanged	The new version has a different format than the previous one. New: Microsoft.Capacity/stable/2022-03-01/reservations.json#L2596:13 Old: Microsoft.Capacity/preview/2020-10-01-preview/reservations.json#L1548:13
⚠️ 1023 - TypeFormatChanged	The new version has a different format than the previous one. New: Microsoft.Capacity/stable/2022-03-01/reservations.json#L1296:9 Old: Microsoft.Capacity/preview/2020-10-01-preview/reservations.json#L1295:9
⚠️ 1023 - TypeFormatChanged	The new version has a different format than the previous one. New: Microsoft.Capacity/stable/2022-03-01/reservations.json#L1532:9 Old: Microsoft.Capacity/preview/2020-10-01-preview/reservations.json#L1472:9
⚠️ 1023 - TypeFormatChanged	The new version has a different format than the previous one. New: Microsoft.Capacity/stable/2022-03-01/reservations.json#L360:9 Old: Microsoft.Capacity/preview/2020-10-01-preview/reservations.json#L339:9
⚠️ 1023 - TypeFormatChanged	The new version has a different format than the previous one. New: Microsoft.Capacity/stable/2022-03-01/reservations.json#L2267:11 Old: Microsoft.Capacity/preview/2020-10-01-preview/reservations.json#L1778:11
⚠️ 1025 - RequiredStatusChange	The 'required' status changed from the old version('True') to the new version('False'). New: Microsoft.Capacity/stable/2022-03-01/reservations.json#L83:9 Old: Microsoft.Capacity/preview/2020-10-01-preview/reservations.json#L83:9
⚠️ 1025 - RequiredStatusChange	The 'required' status changed from the old version('True') to the new version('False'). New: Microsoft.Capacity/stable/2022-03-01/reservations.json#L2807:5 Old: Microsoft.Capacity/preview/2020-10-01-preview/reservations.json#L2236:5
⚠️ 1029 - ReadonlyPropertyChanged	The read only property has changed from 'true' to 'false'. New: Microsoft.Capacity/stable/2022-03-01/reservations.json#L1528:9 Old: Microsoft.Capacity/preview/2020-10-01-preview/reservations.json#L1467:9

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️️✔️SDK Track2 Validation succeeded [Detail] [Expand]

Validation passes for SDKTrack2Validation

The following tags are being changed in this PR

reservations/resource-manager/readme.md#package-2022-03

️️✔️PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-workflow-bot · 2022-03-15T01:05:57Z

[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

openapi-pipeline-app · 2022-03-15T01:05:58Z

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

️❌SDK Breaking Change Tracking failed [Detail]

Breaking Changes Tracking

❌azure-sdk-for-go-track2 - armreservations - 0.3.0

❌azure-sdk-for-python-track2 - track2_azure-mgmt-reservations - 1.0.0

+	Operation AzureReservationAPIOperationsMixin.get_catalog has a new signature
+	Operation AzureReservationAPIOperationsMixin.get_catalog has a new signature
+	Operation AzureReservationAPIOperationsMixin.get_catalog has a new signature

️✔️azure-sdk-for-go - reservations/mgmt/2021-07-01/reservations - v62.2.0
️✔️azure-sdk-for-go - reservations/mgmt/2017-11-01/reservations - v62.2.0
❌azure-sdk-for-go - preview/reservations/mgmt/2020-10-25/reservations - v62.2.0

️✔️azure-sdk-for-go - preview/reservations/mgmt/2019-07-19-preview/reservations - v62.2.0
️✔️azure-sdk-for-go - preview/reservations/mgmt/2019-04-01/reservations - v62.2.0
️✔️azure-sdk-for-go - preview/reservations/mgmt/2018-06-01/reservations - v62.2.0
❌azure-sdk-for-js - @azure/arm-reservations - 8.0.0

+	Class AzureReservationAPI no longer has parameter quota
+	Class AzureReservationAPI no longer has parameter quotaRequestStatus
+	Removed Enum KnownQuotaRequestState
+	Removed Enum KnownResourceType
+	Removed operation group Quota
+	Removed operation group QuotaRequestStatus

️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 66cfa57. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	sudo apt-get install -y dotnet-sdk-6.0
command	autorest --version=2.0.4421 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/reservations/resource-manager/readme.md
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied

️✔️Microsoft.Azure.Management.Reservations [View full logs] [Release SDK Changes]
- Microsoft.Azure.Management.Reservations.1.15.0-preview.nupkg
- Microsoft.Azure.Management.Reservations.1.15.0-preview.symbols.nupkg

️⚠️ azure-sdk-for-python-track2 warning [Detail]

⚠️Warning [Logs]Release - Generate from 66cfa57. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh] npm notice
cmderr	[automation_generate.sh] npm notice New minor version of npm available! 8.3.1 -> 8.5.5
cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v8.5.5>
cmderr	[automation_generate.sh] npm notice Run `npm install -g [email protected]` to update!
cmderr	[automation_generate.sh] npm notice

️✔️track2_azure-mgmt-reservations [View full logs] [Release SDK Changes] Breaking Change Detected

info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Added operation ReservationOperations.list_all
info	[Changelog]   - Added operation ReservationOrderOperations.change_directory
info	[Changelog]   - Model CalculatePriceResponseProperties has a new parameter grand_total
info	[Changelog]   - Model CalculatePriceResponseProperties has a new parameter is_tax_included
info	[Changelog]   - Model CalculatePriceResponseProperties has a new parameter net_total
info	[Changelog]   - Model CalculatePriceResponseProperties has a new parameter tax_total
info	[Changelog]   - Model Catalog has a new parameter capabilities
info	[Changelog]   - Model Catalog has a new parameter msrp
info	[Changelog]   - Model Catalog has a new parameter size
info	[Changelog]   - Model Catalog has a new parameter tier
info	[Changelog]   - Model CurrentQuotaLimit has a new parameter id
info	[Changelog]   - Model CurrentQuotaLimit has a new parameter name
info	[Changelog]   - Model CurrentQuotaLimit has a new parameter type
info	[Changelog]   - Model CurrentQuotaLimitBase has a new parameter id
info	[Changelog]   - Model CurrentQuotaLimitBase has a new parameter name
info	[Changelog]   - Model CurrentQuotaLimitBase has a new parameter type
info	[Changelog]   - Model OperationResponse has a new parameter is_data_action
info	[Changelog]   - Model OperationResponse has a new parameter properties
info	[Changelog]   - Model QuotaRequestOneResourceSubmitResponse has a new parameter id_properties_id
info	[Changelog]   - Model QuotaRequestOneResourceSubmitResponse has a new parameter name_properties_name
info	[Changelog]   - Model QuotaRequestOneResourceSubmitResponse has a new parameter type_properties_type
info	[Changelog]   - Model ReservationOrderResponse has a new parameter benefit_start_time
info	[Changelog]   - Model ReservationOrderResponse has a new parameter system_data
info	[Changelog]   - Model ReservationResponse has a new parameter kind
info	[Changelog]   - Model ReservationResponse has a new parameter system_data
info	[Changelog]
info	[Changelog] **Breaking changes**
info	[Changelog]
info	[Changelog]   - Operation AzureReservationAPIOperationsMixin.get_catalog has a new signature
info	[Changelog]   - Operation AzureReservationAPIOperationsMixin.get_catalog has a new signature
info	[Changelog]   - Operation AzureReservationAPIOperationsMixin.get_catalog has a new signature

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 66cfa57. SDK Automation 14.0.0

command	sh ./eng/initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️reservations/mgmt/2021-07-01/reservations [View full logs] [Release SDK Changes]
```
info	[Changelog] This is a new package
info	[Changelog]
```

️✔️reservations/mgmt/2017-11-01/reservations [View full logs]

info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).

️✔️preview/reservations/mgmt/2020-10-25/reservations [View full logs]

Only show 20 items here, please refer to log for details.

info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - New const `ResourceTypeLowPriority`
info	[Changelog] - New const `QuotaRequestStateInvalid`
info	[Changelog] - New const `ResourceTypeStandard`
info	[Changelog] - New const `QuotaRequestStateAccepted`
info	[Changelog] - New const `ResourceTypeServiceSpecific`
info	[Changelog] - New const `QuotaRequestStateSucceeded`
info	[Changelog] - New const `ResourceTypeDedicated`
info	[Changelog] - New const `ResourceTypeShared`
info	[Changelog] - New const `QuotaRequestStateInProgress`
info	[Changelog] - New const `QuotaRequestStateFailed`
info	[Changelog] - New function `CurrentQuotaLimitBase.MarshalJSON() ([]byte, error)`
info	[Changelog] - New function `PossibleResourceTypeValues() []ResourceType`
info	[Changelog] - New function `PossibleQuotaRequestStateValues() []QuotaRequestState`
info	[Changelog] - New field `ID` in struct `CurrentQuotaLimitBase`
info	[Changelog] - New field `Name` in struct `CurrentQuotaLimitBase`
info	[Changelog] - New field `Type` in struct `CurrentQuotaLimitBase`
info	[Changelog]
info	[Changelog] Total 5 breaking change(s), 14 additive change(s).

️✔️preview/reservations/mgmt/2019-07-19-preview/reservations [View full logs]

info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - New struct `AppliedScopeProperties`
info	[Changelog] - New struct `MsrpProperty`
info	[Changelog] - New struct `SwapProperties`
info	[Changelog] - New field `SwapProperties` in struct `PropertiesType`
info	[Changelog] - New field `AppliedScopeProperties` in struct `PropertiesType`
info	[Changelog] - New field `Capabilities` in struct `PropertiesType`
info	[Changelog] - New field `Archived` in struct `PropertiesType`
info	[Changelog] - New field `Reason` in struct `ScopeProperties`
info	[Changelog] - New field `InstanceFlexibility` in struct `PurchaseRequestProperties`
info	[Changelog] - New field `Msrp` in struct `Catalog`
info	[Changelog] - New field `NetTotal` in struct `CalculatePriceResponseProperties`
info	[Changelog] - New field `TaxTotal` in struct `CalculatePriceResponseProperties`
info	[Changelog] - New field `GrandTotal` in struct `CalculatePriceResponseProperties`
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 11 additive change(s).

️✔️preview/reservations/mgmt/2019-04-01/reservations [View full logs]

info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - New struct `AppliedScopeProperties`
info	[Changelog] - New struct `MsrpProperty`
info	[Changelog] - New struct `SwapProperties`
info	[Changelog] - New field `InstanceFlexibility` in struct `PurchaseRequestProperties`
info	[Changelog] - New field `Reason` in struct `ScopeProperties`
info	[Changelog] - New field `Msrp` in struct `Catalog`
info	[Changelog] - New field `Capabilities` in struct `PropertiesType`
info	[Changelog] - New field `SwapProperties` in struct `PropertiesType`
info	[Changelog] - New field `Archived` in struct `PropertiesType`
info	[Changelog] - New field `AppliedScopeProperties` in struct `PropertiesType`
info	[Changelog] - New field `NetTotal` in struct `CalculatePriceResponseProperties`
info	[Changelog] - New field `GrandTotal` in struct `CalculatePriceResponseProperties`
info	[Changelog] - New field `TaxTotal` in struct `CalculatePriceResponseProperties`
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 11 additive change(s).

️✔️preview/reservations/mgmt/2018-06-01/reservations [View full logs]

info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).

️️✔️ azure-sdk-for-go-track2 succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 66cfa57. SDK Automation 14.0.0

command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️armreservations [View full logs] [Release SDK Changes] Breaking Change Detected

info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog] - Type of `OperationResponse.Properties` has been changed from `map[string]interface{}` to `interface{}`
info	[Changelog] - Type of `QuotaProperties.Properties` has been changed from `map[string]interface{}` to `interface{}`
info	[Changelog] - Function `QuotaLimitsResponse.MarshalJSON` has been removed
info	[Changelog] - Function `CreateGenericQuotaRequestParameters.MarshalJSON` has been removed
info	[Changelog] - Function `*QuotaRequestOneResourceProperties.UnmarshalJSON` has been removed
info	[Changelog] - Function `ServiceError.MarshalJSON` has been removed
info	[Changelog] - Function `QuotaRequestOneResourceProperties.MarshalJSON` has been removed
info	[Changelog] - Struct `CreateGenericQuotaRequestParameters` has been removed
info	[Changelog] - Struct `CurrentQuotaLimit` has been removed
info	[Changelog] - Struct `Error` has been removed
info	[Changelog] - Struct `ErrorDetails` has been removed
info	[Changelog] - Struct `ErrorResponse` has been removed
info	[Changelog] - Struct `ExceptionResponse` has been removed
info	[Changelog] - Struct `ExtendedErrorInfo` has been removed
info	[Changelog] - Struct `QuotaLimitsResponse` has been removed
info	[Changelog] - Struct `QuotaRequestOneResourceProperties` has been removed
info	[Changelog] - Struct `QuotaRequestOneResourceSubmitResponse` has been removed
info	[Changelog] - Struct `QuotaRequestSubmitResponse` has been removed
info	[Changelog] - Struct `ServiceError` has been removed
info	[Changelog] - Struct `ServiceErrorDetail` has been removed
info	[Changelog] - Field `QuotaRequestOneResourceSubmitResponse` of struct `QuotaClientCreateOrUpdateResult` has been removed
info	[Changelog] - Field `QuotaRequestOneResourceSubmitResponse` of struct `QuotaClientUpdateResult` has been removed
info	[Changelog]
info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - New anonymous field `CurrentQuotaLimitBase` in struct `QuotaClientCreateOrUpdateResult`
info	[Changelog] - New field `BenefitStartTime` in struct `ReservationOrderProperties`
info	[Changelog] - New field `BenefitStartTime` in struct `Properties`
info	[Changelog] - New anonymous field `CurrentQuotaLimitBase` in struct `QuotaClientUpdateResult`
info	[Changelog] - New field `PublisherID` in struct `AzureReservationAPIClientGetCatalogOptions`
info	[Changelog] - New field `OfferID` in struct `AzureReservationAPIClientGetCatalogOptions`
info	[Changelog] - New field `PlanID` in struct `AzureReservationAPIClientGetCatalogOptions`
info	[Changelog] - New field `ID` in struct `CurrentQuotaLimitBase`
info	[Changelog] - New field `Name` in struct `CurrentQuotaLimitBase`
info	[Changelog] - New field `Type` in struct `CurrentQuotaLimitBase`
info	[Changelog]
info	[Changelog] Total 35 breaking change(s), 6 additive change(s).

️⚠️ azure-sdk-for-js warning [Detail]

⚠️Warning [Logs]Release - Generate from 66cfa57. SDK Automation 14.0.0

command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
cmderr	[automation_init.sh] deprecated [email protected]: The functionality that this package provided is now in @npmcli/arborist
cmderr	[automation_init.sh] deprecated [email protected]: Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
cmderr	[automation_init.sh]  @opentelemetry/[email protected]: Package renamed to @opentelemetry/api, see https://github.com/open-telemetry/opentelemetry-js
cmderr	[automation_init.sh]  @octokit/[email protected] requires a peer of @octokit/core@>=3 but none is installed. You must install peer dependencies yourself.
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json

️✔️@azure/arm-reservations [View full logs] [Release SDK Changes]

azure-arm-reservations-7.1.0.tgz

info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Interface CurrentQuotaLimit has a new optional parameter id
info	[Changelog]   - Interface CurrentQuotaLimit has a new optional parameter name
info	[Changelog]   - Interface CurrentQuotaLimit has a new optional parameter type
info	[Changelog]   - Interface CurrentQuotaLimitBase has a new optional parameter id
info	[Changelog]   - Interface CurrentQuotaLimitBase has a new optional parameter name
info	[Changelog]   - Interface CurrentQuotaLimitBase has a new optional parameter type
info	[Changelog]   - Interface GetCatalogOptionalParams has a new optional parameter offerId
info	[Changelog]   - Interface GetCatalogOptionalParams has a new optional parameter planId
info	[Changelog]   - Interface GetCatalogOptionalParams has a new optional parameter publisherId
info	[Changelog]   - Interface QuotaRequestOneResourceSubmitResponse has a new optional parameter idPropertiesId
info	[Changelog]   - Interface QuotaRequestOneResourceSubmitResponse has a new optional parameter namePropertiesName
info	[Changelog]   - Interface QuotaRequestOneResourceSubmitResponse has a new optional parameter typePropertiesType
info	[Changelog]   - Interface ReservationOrderResponse has a new optional parameter benefitStartTime
info	[Changelog]   - Interface ReservationsProperties has a new optional parameter benefitStartTime
error	breakingChangeTracking is enabled, but version or changelogItem is not found in output.

️⚠️ azure-resource-manager-schemas warning [Detail]

⚠️Warning [Logs]Release - Generate from 66cfa57. Schema Automation 14.0.0

command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh] WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
cmderr	[initScript.sh] npm WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
cmderr	[initScript.sh] npm WARN old lockfile
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json

️✔️reservations [View full logs] [Release Schema Changes]

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-workflow-bot · 2022-03-15T01:08:02Z

Hi @gaoyp830, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.

Task	How to fix	Priority
Avocado	Fix-Avocado	High
Semantic validation	Fix-SemanticValidation-Error	High
Model validation	Fix-ModelValidation-Error	High
LintDiff	Fix-LintDiff	high

If you need further help, please feedback via swagger feedback.

openapi-workflow-bot · 2022-03-15T01:23:22Z

Hi, @gaoyp830 your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board([email protected]).

gaoyp830 · 2022-03-15T20:35:55Z

Hi @weidongxu-microsoft could you please reapprove/take a look at this PR with the latest commit? The check "API Readiness Check" failed because we havent update manifest in our service with API version 2022-03-01 since this is a new version. We will add that new version once we get sign off on this PR.

weidongxu-microsoft · 2022-03-16T01:33:58Z

@gaoyp830
Approved.

I am not sure why use $publisherId instead of publisherId. You might want to check with any ARM person.

gaoyp830 · 2022-03-16T21:37:19Z

@gaoyp830 Approved.

I am not sure why use $publisherId instead of publisherId. You might want to check with any ARM person.

@weidongxu-microsoft Thanks for the suggestion! '$' was added by mistake, I have removed them in the new commit. Please take a look and help merge the PR as I cannot merge it.

Thanks again for the help!

weidongxu-microsoft · 2022-03-21T02:18:27Z

@gaoyp830

2 things to confirm:

the $ is related to service implementation, the implementation had to accept e.g. /subscriptions/{subscriptionId}/providers/Microsoft.Capacity/catalogs?publisherId=xxx
the name change of from FulfillmentCreatedDateTime to BenefitStartTime only happen to the new property added to this api-version

gaoyp830 · 2022-03-21T02:30:33Z

@gaoyp830

2 things to confirm:

the $ is related to service implementation, the implementation had to accept e.g. /subscriptions/{subscriptionId}/providers/Microsoft.Capacity/catalogs?publisherId=xxx

the name change of from FulfillmentCreatedDateTime to BenefitStartTime only happen to the new property added to this api-version

Hi @weidongxu-microsoft ,

$ was added in this PR by mistake, and it should not be there, i removed it in the new commit. The three parameter publisherId, planId and offerId are optional parameters in the uri, so in this case we accept both '/subscriptions/{subscriptionId}/providers/Microsoft.Capacity/catalogs' and '/subscriptions/{subscriptionId}/providers/Microsoft.Capacity/catalogs?publisherId=xxx`
Yes FulfillmentCreatedDateTime is a new property added to the API spec(which is why i am introducing the new API version 2022-03-01 here), but then I got a requirement to change the name to 'BenefitStartTime'. So this new property only exists in version 2022-03-01.

weidongxu-microsoft · 2022-03-21T02:35:49Z

Merged.

Seems RP roll-out is not completed. It is recommended to ask SDK after roll-out complete (or at least notify the expected completion date in SDK request).

….Capacity to add version stable/2022-03-01 (#2263) Create to sync Azure/azure-rest-api-specs#18244 [ReCreate this PR](https://github.com/azure-resource-manager-schemas/compare/main...AzureSDKAutomation:sdkAuto/reservations?expand=1)

…stable/2022-03-01 (Azure#18244) * Adds base for updating Microsoft.Capacity from version stable/2021-07-01 to version 2022-03-01 * Updates readme * Updates API version in new specs and examples * Update with new changes * include quota.json in readme * Remove dollar sign for publisher id * Change name from FulfillmentCreatedDateTime to BenefitStartTime

gaoyp830 added 3 commits March 14, 2022 18:02

Adds base for updating Microsoft.Capacity from version stable/2021-07…

f78dfe3

…-01 to version 2022-03-01

Updates readme

b160cac

Updates API version in new specs and examples

e84acc5

openapi-assignment-bot bot assigned weidongxu-microsoft Mar 15, 2022

openapi-pipeline-app bot added the CI-FixRequiredOnFailure label Mar 15, 2022

openapi-sdkautomation bot mentioned this pull request Mar 15, 2022

[AutoPR reservations] [Hub Generated] Review request for Microsoft.Capacity to add version stable/2022-03-01 AzureSDKAutomation/azure-resource-manager-schemas#5970

Closed

openapi-pipeline-app bot added the CI-BreakingChange-Go-V2 label Mar 15, 2022

openapi-sdkautomation bot mentioned this pull request Mar 15, 2022

[AutoPR track2_azure-mgmt-reservations] [Hub Generated] Review request for Microsoft.Capacity to add version stable/2022-03-01 AzureSDKAutomation/azure-sdk-for-python#9595

Closed

openapi-pipeline-app bot added the CI-BreakingChange-Python-Track2 label Mar 15, 2022

openapi-pipeline-app bot added the CI-BreakingChange-JavaScript label Mar 15, 2022

Update with new changes

de70b9c

openapi-workflow-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Mar 15, 2022

include quota.json in readme

9d2fc18

gaoyp830 closed this Mar 15, 2022

weidongxu-microsoft approved these changes Mar 15, 2022

View reviewed changes

gaoyp830 reopened this Mar 15, 2022

gaoyp830 mentioned this pull request Mar 15, 2022

Adding 2022-03-01 version for Microsoft.Capacity with new changes #18175

Closed

25 tasks

openapi-pipeline-app bot removed the CI-BreakingChange-JavaScript label Mar 15, 2022

gaoyp830 requested a review from weidongxu-microsoft March 15, 2022 02:16

weidongxu-microsoft approved these changes Mar 16, 2022

View reviewed changes

weidongxu-microsoft added the Approved-OkToMerge <valid label in PR review process>add this label when assignee approve to merge the updates label Mar 16, 2022

raosuhas added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Mar 16, 2022

Remove dollar sign for publisher id

6f88c6c

Change name from FulfillmentCreatedDateTime to BenefitStartTime

5381dce

weidongxu-microsoft merged commit 66cfa57 into Azure:main Mar 21, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Hub Generated] Review request for Microsoft.Capacity to add version stable/2022-03-01 #18244

[Hub Generated] Review request for Microsoft.Capacity to add version stable/2022-03-01 #18244

gaoyp830 commented Mar 15, 2022 •

edited

Loading

openapi-workflow-bot bot commented Mar 15, 2022

openapi-pipeline-app bot commented Mar 15, 2022 •

edited

Loading

openapi-workflow-bot bot commented Mar 15, 2022

openapi-pipeline-app bot commented Mar 15, 2022 •

edited

Loading

Breaking Changes Tracking

openapi-workflow-bot bot commented Mar 15, 2022

openapi-workflow-bot bot commented Mar 15, 2022

gaoyp830 commented Mar 15, 2022

weidongxu-microsoft commented Mar 16, 2022

gaoyp830 commented Mar 16, 2022

weidongxu-microsoft commented Mar 21, 2022

gaoyp830 commented Mar 21, 2022

weidongxu-microsoft commented Mar 21, 2022

[Hub Generated] Review request for Microsoft.Capacity to add version stable/2022-03-01 #18244

[Hub Generated] Review request for Microsoft.Capacity to add version stable/2022-03-01 #18244

Conversation

gaoyp830 commented Mar 15, 2022 • edited Loading

Changelog

Contribution checklist:

ARM API Review Checklist

Breaking Change Review Checklist

openapi-workflow-bot bot commented Mar 15, 2022

openapi-pipeline-app bot commented Mar 15, 2022 • edited Loading

Swagger Validation Report

openapi-workflow-bot bot commented Mar 15, 2022

openapi-pipeline-app bot commented Mar 15, 2022 • edited Loading

Swagger Generation Artifacts

Breaking Changes Tracking

openapi-workflow-bot bot commented Mar 15, 2022

openapi-workflow-bot bot commented Mar 15, 2022

gaoyp830 commented Mar 15, 2022

weidongxu-microsoft commented Mar 16, 2022

gaoyp830 commented Mar 16, 2022

weidongxu-microsoft commented Mar 21, 2022

gaoyp830 commented Mar 21, 2022

weidongxu-microsoft commented Mar 21, 2022

gaoyp830 commented Mar 15, 2022 •

edited

Loading

openapi-pipeline-app bot commented Mar 15, 2022 •

edited

Loading

openapi-pipeline-app bot commented Mar 15, 2022 •

edited

Loading